chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc - Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removing non ContainsValue changes Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/predictors/autocomplete_action_predictor.cc ('K') | « chrome/browser/ui/toolbar/toolbar_actions_model.cc ('k') | chrome/browser/ui/webui/chromeos/login/l10n_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

index 5bf0eec18fa0e83f7a94661b839aa5be2c602621..9548c56526911d6c5e0b6f207ddb4d2ad6691722 100644

--- a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc

@@ -9,6 +9,7 @@

#include "base/guid.h"

#include "base/logging.h"

#include "base/metrics/histogram.h"

+#include "base/stl_util.h"

#include "base/strings/utf_string_conversions.h"

#include "base/values.h"

#include "chrome/browser/browser_process.h"

@@ -125,8 +126,7 @@ void PushFrontIMIfNotExists(const std::string& input_method,

if (input_method.empty())

return;

- if (std::find(input_methods->begin(), input_methods->end(), input_method) ==

- input_methods->end())

+ if (!ContainsValue(*input_methods, input_method))

input_methods->insert(input_methods->begin(), input_method);

}