chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm - Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per latest code Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/themes/browser_theme_pack.cc ('K') | « chrome/browser/ui/android/website_settings_popup_android.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_model.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

index 7865cef9cd1e971c704729430ac4dea0c073d46f..59e9191f79766c847a95d464d9211d3493581da5 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

@@ -10,6 +10,7 @@

#include "base/mac/sdk_forward_declarations.h"

#include "base/macros.h"

#include "base/run_loop.h"

+#include "base/stl_util.h"

#include "base/strings/utf_string_conversions.h"

#include "chrome/app/chrome_command_ids.h"

#include "chrome/browser/browser_process.h"

@@ -261,7 +262,7 @@ class BrowserWindowControllerTest : public InProcessBrowserTest {

// Views not in |view_list| must either be nil or not parented.

for (size_t i = 0; i < VIEW_ID_COUNT; ++i) {

- if (std::find(view_list.begin(), view_list.end(), i) == view_list.end()) {

+ if (!ContainsValue(view_list, i)) {

NSView* view = GetViewWithID(static_cast<ViewID>(i));

EXPECT_TRUE(!view || ![view superview]);

}