chrome/browser/predictors/autocomplete_action_predictor.cc - Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/autocomplete_action_predictor.cc

Issue 1715683002: chrome: Use base's ContainsValue helper function instead of std::find (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per latest code Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/platform_keys/platform_keys_service.cc ('K') | « chrome/browser/extensions/external_provider_impl.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc » ('j') | chrome/browser/spellchecker/spellcheck_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/autocomplete_action_predictor.cc

diff --git a/chrome/browser/predictors/autocomplete_action_predictor.cc b/chrome/browser/predictors/autocomplete_action_predictor.cc

index dd799b9fa1004b2f2f9b779389f7851bffe376b1..34ecace778c3593c4a77f30fd990fe975e550745 100644

--- a/chrome/browser/predictors/autocomplete_action_predictor.cc

+++ b/chrome/browser/predictors/autocomplete_action_predictor.cc

@@ -14,6 +14,7 @@

#include "base/i18n/case_conversion.h"

#include "base/macros.h"

#include "base/metrics/histogram.h"

+#include "base/stl_util.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

@@ -128,8 +129,7 @@ void AutocompleteActionPredictor::RegisterTransitionalMatches(

}

for (const auto& i : result) {

- if (std::find(match_it->urls.begin(), match_it->urls.end(),

- i.destination_url) == match_it->urls.end()) {

+ if (!ContainsValue(match_it->urls, i.destination_url)) {

sky 2016/03/02 17:19:34 nit: no {}

chakshu 2016/03/07 08:10:46 Done.

match_it->urls.push_back(i.destination_url);

}