chrome: Use base's ContainsValue helper function instead of std::find

chrome: Use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
Committed: https://crrev.com/c20f387895601a5f9de440683c3faa9d66c7c485
Cr-Commit-Position: refs/heads/master@{#385427}

[chakshu, 2016-02-19 13:01:57]

The CQ bit was checked by chakshu.a@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 13:04:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715683002/1

[commit-bot: I haz the power, 2016-02-19 13:04:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 13:04:27]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[vivekg, 2016-02-19 13:18:10]

The CQ bit was checked by vivekg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 13:20:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715683002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715683002/1

[commit-bot: I haz the power, 2016-02-19 13:26:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 13:26:49]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[vivekg, 2016-02-19 14:48:01]

The CQ bit was checked by vivekg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 14:51:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715683002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715683002/20001

[commit-bot: I haz the power, 2016-02-19 15:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 15:49:00]

Dry run: This issue passed the CQ dry run.

[vivekg, 2016-02-22 06:21:36]

On 2016/02/19 15:49:00, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

looks good to me!

[chakshu, 2016-02-22 06:35:27]

Description was changed from

==========
Use ContainsValue instead of std::find() of base/stl_util.h where appropriate

BUG=561800
==========

to

==========
chrome: Use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
==========

[chakshu, 2016-02-22 06:35:27]

chakshu.a@samsung.com changed reviewers:
+ sky@chromium.org

[chakshu, 2016-02-24 10:20:26]

On 2016/02/22 06:21:36, vivekg_ wrote:
> On 2016/02/19 15:49:00, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> looks good to me!

@sky Can you please take a look at this?

[chakshu, 2016-03-02 05:28:53]

On 2016/02/24 10:20:26, chakshu wrote:
> On 2016/02/22 06:21:36, vivekg_ wrote:
> > On 2016/02/19 15:49:00, commit-bot: I haz the power wrote:
> > > Dry run: This issue passed the CQ dry run.
> > 
> > looks good to me!
> 
> @sky Can you please take a look at this?

Friendly ping again.

[sky, 2016-03-02 17:19:35]

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_util.cc:693:
std::vector<std::string> new_ids;
Make this use std::unique

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/controller_pairing_screen.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:156: if
(!ContainsValue(devices, selected_device)) {
nit: no {}

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:427: if
(!ContainsValue(accepted_types, actual_key_type)) {
nit: no {}

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/autocomplete_action_predictor.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/autocomplete_action_predictor.cc:132: if
(!ContainsValue(match_it->urls, i.destination_url)) {
nit: no {}

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_service.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:357: for (const auto&
dictionary : dictionaries) {
Isn't this std::set_intersection?

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:358: if
(ContainsValue(accept_languages, dictionary)) {
nit: no {}

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:890: if
(!ContainsValue(scale_factors_, ui::SCALE_FACTOR_100P)) {
nit: no {}

[sky, 2016-03-02 18:00:36]

Also, run git cl format

On Wed, Mar 2, 2016 at 9:19 AM,  <sky@chromium.org> wrote:
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/input_method/input_method_util.cc (right):
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/input_method/input_method_util.cc:693:
> std::vector<std::string> new_ids;
> Make this use std::unique
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/screens/controller_pairing_screen.cc
> (right):
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:156:
> if (!ContainsValue(devices, selected_device)) {
> nit: no {}
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/platform_keys/platform_keys_service.cc
> (right):
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/platform_keys/platform_keys_service.cc:427: if
> (!ContainsValue(accepted_types, actual_key_type)) {
> nit: no {}
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
> File chrome/browser/predictors/autocomplete_action_predictor.cc (right):
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
> chrome/browser/predictors/autocomplete_action_predictor.cc:132: if
> (!ContainsValue(match_it->urls, i.destination_url)) {
> nit: no {}
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
> File chrome/browser/spellchecker/spellcheck_service.cc (right):
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
> chrome/browser/spellchecker/spellcheck_service.cc:357: for (const auto&
> dictionary : dictionaries) {
> Isn't this std::set_intersection?
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
> chrome/browser/spellchecker/spellcheck_service.cc:358: if
> (ContainsValue(accept_languages, dictionary)) {
> nit: no {}
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
> File chrome/browser/themes/browser_theme_pack.cc (right):
>
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
> chrome/browser/themes/browser_theme_pack.cc:890: if
> (!ContainsValue(scale_factors_, ui::SCALE_FACTOR_100P)) {
> nit: no {}
>
> https://codereview.chromium.org/1715683002/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chakshu, 2016-03-07 08:10:47]

Changes as per review comments

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_util.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_util.cc:693:
std::vector<std::string> new_ids;
On 2016/03/02 17:19:34, sky wrote:
> Make this use std::unique

Done.

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/controller_pairing_screen.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:156: if
(!ContainsValue(devices, selected_device)) {
On 2016/03/02 17:19:34, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/platform_keys/platform_keys_service.cc:427: if
(!ContainsValue(accepted_types, actual_key_type)) {
On 2016/03/02 17:19:34, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
File chrome/browser/predictors/autocomplete_action_predictor.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
chrome/browser/predictors/autocomplete_action_predictor.cc:132: if
(!ContainsValue(match_it->urls, i.destination_url)) {
On 2016/03/02 17:19:34, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
File chrome/browser/spellchecker/spellcheck_service.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:357: for (const auto&
dictionary : dictionaries) {
On 2016/03/02 17:19:34, sky wrote:
> Isn't this std::set_intersection?

Yes, probably it is. Made the changes using set_intersection. But dictionaries
and accept_languages are now sorted. If that does not make any difference, it
should be fine.

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
chrome/browser/spellchecker/spellcheck_service.cc:358: if
(ContainsValue(accept_languages, dictionary)) {
On 2016/03/02 17:19:34, sky wrote:
> nit: no {}

Done.

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
File chrome/browser/themes/browser_theme_pack.cc (right):

https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
chrome/browser/themes/browser_theme_pack.cc:890: if
(!ContainsValue(scale_factors_, ui::SCALE_FACTOR_100P)) {
On 2016/03/02 17:19:35, sky wrote:
> nit: no {}

Done.

[chakshu, 2016-03-22 11:35:26]

On 2016/03/07 08:10:47, chakshu wrote:
> Changes as per review comments
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/input_method/input_method_util.cc (right):
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/input_method/input_method_util.cc:693:
> std::vector<std::string> new_ids;
> On 2016/03/02 17:19:34, sky wrote:
> > Make this use std::unique
> 
> Done.
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/login/screens/controller_pairing_screen.cc
(right):
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/login/screens/controller_pairing_screen.cc:156: if
> (!ContainsValue(devices, selected_device)) {
> On 2016/03/02 17:19:34, sky wrote:
> > nit: no {}
> 
> Done.
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> File chrome/browser/chromeos/platform_keys/platform_keys_service.cc (right):
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/chromeos...
> chrome/browser/chromeos/platform_keys/platform_keys_service.cc:427: if
> (!ContainsValue(accepted_types, actual_key_type)) {
> On 2016/03/02 17:19:34, sky wrote:
> > nit: no {}
> 
> Done.
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
> File chrome/browser/predictors/autocomplete_action_predictor.cc (right):
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/predicto...
> chrome/browser/predictors/autocomplete_action_predictor.cc:132: if
> (!ContainsValue(match_it->urls, i.destination_url)) {
> On 2016/03/02 17:19:34, sky wrote:
> > nit: no {}
> 
> Done.
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
> File chrome/browser/spellchecker/spellcheck_service.cc (right):
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
> chrome/browser/spellchecker/spellcheck_service.cc:357: for (const auto&
> dictionary : dictionaries) {
> On 2016/03/02 17:19:34, sky wrote:
> > Isn't this std::set_intersection?
> 
> Yes, probably it is. Made the changes using set_intersection. But dictionaries
> and accept_languages are now sorted. If that does not make any difference, it
> should be fine.
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/spellche...
> chrome/browser/spellchecker/spellcheck_service.cc:358: if
> (ContainsValue(accept_languages, dictionary)) {
> On 2016/03/02 17:19:34, sky wrote:
> > nit: no {}
> 
> Done.
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
> File chrome/browser/themes/browser_theme_pack.cc (right):
> 
>
https://codereview.chromium.org/1715683002/diff/20001/chrome/browser/themes/b...
> chrome/browser/themes/browser_theme_pack.cc:890: if
> (!ContainsValue(scale_factors_, ui::SCALE_FACTOR_100P)) {
> On 2016/03/02 17:19:35, sky wrote:
> > nit: no {}
> 
> Done.

@sky Can you please review these changes as you suggested?

[sky, 2016-03-22 16:20:29]

Please separate out the non ContainsValue to a separate patch and get local
owners to review.

[chakshu, 2016-03-24 13:02:58]

On 2016/03/22 16:20:29, sky wrote:
> Please separate out the non ContainsValue to a separate patch and get local
> owners to review.

Done !
And non ContainsValue patch has been updated
https://codereview.chromium.org/1830543003/

[chakshu, 2016-04-04 05:34:17]

On 2016/03/24 13:02:58, chakshu wrote:
> On 2016/03/22 16:20:29, sky wrote:
> > Please separate out the non ContainsValue to a separate patch and get local
> > owners to review.
> 
> Done !
> And non ContainsValue patch has been updated
> https://codereview.chromium.org/1830543003/

@sky Can you please review this ContainsValue patch so that it is good to land?

[sky, 2016-04-04 15:39:00]

https://codereview.chromium.org/1715683002/diff/60001/chrome/browser/predicto...
File chrome/browser/predictors/autocomplete_action_predictor.cc (right):

https://codereview.chromium.org/1715683002/diff/60001/chrome/browser/predicto...
chrome/browser/predictors/autocomplete_action_predictor.cc:131: for (const auto&
i : result)
keep the {} here.

[chakshu, 2016-04-05 05:03:36]

Changes made according to review comments

https://codereview.chromium.org/1715683002/diff/60001/chrome/browser/predicto...
File chrome/browser/predictors/autocomplete_action_predictor.cc (right):

https://codereview.chromium.org/1715683002/diff/60001/chrome/browser/predicto...
chrome/browser/predictors/autocomplete_action_predictor.cc:131: for (const auto&
i : result)
On 2016/04/04 15:39:00, sky wrote:
> keep the {} here.

Done.

[sky, 2016-04-05 16:55:15]

LGTM

[chakshu, 2016-04-06 04:47:57]

The CQ bit was checked by chakshu.a@samsung.com

[chakshu, 2016-04-06 04:47:57]

The CQ bit was unchecked by chakshu.a@samsung.com

[chakshu, 2016-04-06 04:48:39]

The CQ bit was checked by chakshu.a@samsung.com

[commit-bot: I haz the power, 2016-04-06 04:49:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715683002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715683002/80001

[commit-bot: I haz the power, 2016-04-06 04:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 04:51:50]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[chakshu, 2016-04-06 09:07:37]

The CQ bit was checked by chakshu.a@samsung.com

[chakshu, 2016-04-06 09:07:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1715683002/#ps100001
(title: "Updated as per latest code")

[commit-bot: I haz the power, 2016-04-06 09:08:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1715683002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1715683002/100001

[commit-bot: I haz the power, 2016-04-06 09:58:17]

Description was changed from

==========
chrome: Use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
==========

to

==========
chrome: Use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
==========

[commit-bot: I haz the power, 2016-04-06 09:58:18]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-06 09:59:43]

Description was changed from

==========
chrome: Use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800
==========

to

==========
chrome: Use base's ContainsValue helper function instead of std::find

This simplifies many conditions around the code.

BUG=561800

Committed: https://crrev.com/c20f387895601a5f9de440683c3faa9d66c7c485
Cr-Commit-Position: refs/heads/master@{#385427}
==========

[commit-bot: I haz the power, 2016-04-06 09:59:44]

Patchset 6 (id:??) landed as
https://crrev.com/c20f387895601a5f9de440683c3faa9d66c7c485
Cr-Commit-Position: refs/heads/master@{#385427}