Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1715633002: [turbofan] Remove the JSContextRelaxation reducer. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Jarin, *danno
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the JSContextRelaxation reducer. This reducer doesn't really add value, because: (a) it is only concerned with JSCallFunction and JSToNumber, but when we get to it, all JSCallFunction nodes will have been replaced by Call nodes, and in the not so far future, we will also have replaced almost all JSToNumber nodes with better code, (b) and the reducer tries to be smart and use one of the outermost contexts, but that might not be beneficial always; actually it might even create longer live ranges and lead to more spilling in some cases. But most importantly, the JSContextRelaxation currently blocks inlining based on SharedFunctionInfo, because it requires the inliner to check the native context, which in turn requires JSFunction knowledge. So I'm removing this reducer for now to unblock the more important inliner changes. R=jarin@chromium.org Committed: https://crrev.com/8a7186b87a40adfa9e89a429688859f7986460c2 Cr-Commit-Position: refs/heads/master@{#34139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -425 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/compiler/frame-states.h View 2 chunks +2 lines, -14 lines 0 comments Download
D src/compiler/js-context-relaxation.h View 1 chunk +0 lines, -32 lines 0 comments Download
D src/compiler/js-context-relaxation.cc View 1 chunk +0 lines, -67 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/unittests/compiler/js-context-relaxation-unittest.cc View 1 chunk +0 lines, -285 lines 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M test/unittests/compiler/liveness-analyzer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-19 06:50:52 UTC) #1
Benedikt Meurer
Hey Jaro, Here's another step for the inliner. Please take a look. Thanks, Benedikt
4 years, 10 months ago (2016-02-19 06:52:15 UTC) #2
Jarin
lgtm, but @danno should have a look.
4 years, 10 months ago (2016-02-19 07:01:50 UTC) #5
danno
This is fine with me. There is little benefit of this optimization if we won't ...
4 years, 10 months ago (2016-02-19 07:41:22 UTC) #6
danno
lgtm
4 years, 10 months ago (2016-02-19 07:42:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715633002/1
4 years, 10 months ago (2016-02-19 07:43:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-19 07:55:30 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 07:55:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a7186b87a40adfa9e89a429688859f7986460c2
Cr-Commit-Position: refs/heads/master@{#34139}

Powered by Google App Engine
This is Rietveld 408576698