Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 171563003: [Files.app] Use util.visitURL to open the webstore link (Closed)

Created:
6 years, 10 months ago by yoshiki
Modified:
6 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

[Files.app] Use util.visitURL to open the webstore link chrome.windows.create has been obsolete and should not be used. BUG=343317 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/file_manager/foreground/js/suggest_apps_dialog.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
yoshiki
hirono: PTAL. Thanks.
6 years, 10 months ago (2014-02-19 02:22:41 UTC) #1
hirono
lgtm!
6 years, 10 months ago (2014-02-19 02:23:03 UTC) #2
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 10 months ago (2014-02-19 02:26:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/171563003/1
6 years, 10 months ago (2014-02-19 02:28:11 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 08:10:32 UTC) #5
Message was sent while issue was closed.
Change committed as 251990

Powered by Google App Engine
This is Rietveld 408576698