Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1715623002: Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. (Closed)

Created:
4 years, 10 months ago by hayato
Modified:
4 years, 10 months ago
Reviewers:
esprehn, kochi
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-navigation-others
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world. BUG=531990 Committed: https://crrev.com/3cc0aa3593626f37fb44e99174f1fa3730e1f14c Cr-Commit-Position: refs/heads/master@{#376480}

Patch Set 1 #

Patch Set 2 : remove dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 36 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/1
4 years, 10 months ago (2016-02-19 06:12:39 UTC) #2
hayato
PTAL
4 years, 10 months ago (2016-02-19 06:14:16 UTC) #5
kochi
lgtm
4 years, 10 months ago (2016-02-19 06:32:18 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1707373002 Patch 20001). Please resolve the dependency and ...
4 years, 10 months ago (2016-02-19 07:03:34 UTC) #13
kochi
On 2016/02/19 07:03:34, commit-bot: I haz the power wrote: > This CL has an open ...
4 years, 10 months ago (2016-02-19 07:15:59 UTC) #14
hayato
remove dependency
4 years, 10 months ago (2016-02-19 07:19:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
4 years, 10 months ago (2016-02-19 07:20:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
4 years, 10 months ago (2016-02-19 07:21:46 UTC) #23
kochi
lgtm
4 years, 10 months ago (2016-02-19 07:26:10 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/25668)
4 years, 10 months ago (2016-02-19 11:13:50 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
4 years, 10 months ago (2016-02-19 11:26:38 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/25815)
4 years, 10 months ago (2016-02-19 15:23:52 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
4 years, 10 months ago (2016-02-19 16:19:53 UTC) #32
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 17:40:38 UTC) #34
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 17:42:51 UTC) #36
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cc0aa3593626f37fb44e99174f1fa3730e1f14c
Cr-Commit-Position: refs/heads/master@{#376480}

Powered by Google App Engine
This is Rietveld 408576698