|
|
Created:
4 years, 10 months ago by hayato Modified:
4 years, 10 months ago CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-navigation-others Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMake a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled.
This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled.
Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world.
BUG=531990
Committed: https://crrev.com/3cc0aa3593626f37fb44e99174f1fa3730e1f14c
Cr-Commit-Position: refs/heads/master@{#376480}
Patch Set 1 #Patch Set 2 : remove dependency #
Messages
Total messages: 36 (21 generated)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/1
Description was changed from ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch after r376090. We do not need to enqueue a microtask unless v1 is enabled. Thus, 'slotchange' event will be zero performance impact for v0 world. BUG=531990 ========== to ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, 'slotchange' event will be zero performance impact for v0 world. BUG=531990 ==========
hayato@chromium.org changed reviewers: + esprehn@chromium.org, kochi@chromium.org
PTAL
lgtm
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
The CQ bit was unchecked by hayato@chromium.org
Description was changed from ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, 'slotchange' event will be zero performance impact for v0 world. BUG=531990 ========== to ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world. BUG=531990 ==========
The CQ bit was checked by hayato@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 1707373002 Patch 20001). Please resolve the dependency and try again.
On 2016/02/19 07:03:34, commit-bot: I haz the power wrote: > This CL has an open dependency (Issue 1707373002 Patch 20001). Please resolve > the dependency and try again. looks this CL has wrong dependency :)
The CQ bit was checked by hayato@chromium.org to run a CQ dry run
remove dependency
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org Link to the patchset: https://codereview.chromium.org/1715623002/#ps20001 (title: "remove dependency")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
The CQ bit was unchecked by hayato@chromium.org
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by hayato@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by esprehn@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715623002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715623002/20001
Message was sent while issue was closed.
Description was changed from ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world. BUG=531990 ========== to ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world. BUG=531990 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world. BUG=531990 ========== to ========== Make a microtask of distribution recalc happen only when ShadowDOMV1 flag is enabled. This is a follow-up patch of r376090. We do not need to enqueue a microtask if v1 is disabled. Thus, having POC of 'slotchange' event for v1 will be zero performance impact for v0 world. BUG=531990 Committed: https://crrev.com/3cc0aa3593626f37fb44e99174f1fa3730e1f14c Cr-Commit-Position: refs/heads/master@{#376480} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3cc0aa3593626f37fb44e99174f1fa3730e1f14c Cr-Commit-Position: refs/heads/master@{#376480} |