Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1715593002: QUIC: obtain source address token keys from internal key server. (Closed)

Created:
4 years, 10 months ago by ramant (doing other things)
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton, mab
CC:
chromium-reviews, cbentzel+watch_chromium.org, mab
Base URL:
https://chromium.googlesource.com/chromium/src.git@114217654
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC: obtain source address token keys from internal key server. We've discovered that the gradual fleet-wide rotation of the internal server's primary key causes a weekly spike of SOURCE_ADDRESS_TOKEN_DECRYPTION_FAILURE, because this key is used to derive QUIC's source address token key. This CL fixes the problem by fetching the key from internal key server, and (for backup) changing QUIC to attempt token decryption using several keys. Merge internal change: 114465990 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -36 lines) Patch
M net/quic/crypto/crypto_secret_boxer.h View 2 chunks +18 lines, -10 lines 0 comments Download
M net/quic/crypto/crypto_secret_boxer.cc View 3 chunks +37 lines, -15 lines 0 comments Download
M net/quic/crypto/crypto_secret_boxer_test.cc View 2 chunks +42 lines, -4 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M net/quic/crypto/quic_crypto_server_config_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
4 years, 10 months ago (2016-02-18 23:09:09 UTC) #1
mab
(Any reason to wait for the fix to be tested with live traffic, before proceeding ...
4 years, 10 months ago (2016-02-19 01:52:41 UTC) #3
Ryan Hamilton
lgtm, but I recommend making the CL description (particularly in the final CL) a bit ...
4 years, 10 months ago (2016-02-19 03:05:48 UTC) #4
ramant (doing other things)
On 2016/02/19 01:52:41, mab wrote: > (Any reason to wait for the fix to be ...
4 years, 10 months ago (2016-02-19 18:30:45 UTC) #5
ramant (doing other things)
4 years, 10 months ago (2016-02-19 18:38:29 UTC) #6
On 2016/02/19 03:05:48, Ryan Hamilton wrote:
> lgtm, but I recommend making the CL description (particularly in the final CL)
a
> bit less internal-focused. Perhaps just mention what's happening in the
Chromium
> change?

Very good point Ryan. Updated the description in the following Landing CL.
Thanks much.

https://codereview.chromium.org/1714713002/

Powered by Google App Engine
This is Rietveld 408576698