Use boolean selector syntax for tags.

test/backend/metadata_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:boolean_selector/boolean_selector.dart';
+
 import 'package:test/src/backend/metadata.dart';
 import 'package:test/src/backend/test_platform.dart';
 import 'package:test/src/frontend/skip.dart';
 import 'package:test/src/frontend/timeout.dart';
 import 'package:test/test.dart';
 
 void main() {
   group("tags", () {
     test("parses an Iterable", () {
       expect(new Metadata.parse(tags: ["a", "b"]).tags,
@@ skipping 30 matching lines @@
   });
 
   group("constructor", () {
     test("returns the normal metadata if there's no forTag", () {
       var metadata = new Metadata(verboseTrace: true, tags: ['foo', 'bar']);
       expect(metadata.verboseTrace, isTrue);
       expect(metadata.tags, equals(['foo', 'bar']));
     });
 
     test("returns the normal metadata if there's no tags", () {
-      var metadata = new Metadata(verboseTrace: true,
-          forTag: {'foo': new Metadata(skip: true)});
+      var metadata = new Metadata(verboseTrace: true, forTag: {
+        new BooleanSelector.parse('foo'): new Metadata(skip: true)
+      });
       expect(metadata.verboseTrace, isTrue);
       expect(metadata.skip, isFalse);
-      expect(metadata.forTag, contains('foo'));
-      expect(metadata.forTag['foo'].skip, isTrue);
+      expect(metadata.forTag, contains(new BooleanSelector.parse('foo')));
+      expect(metadata.forTag[new BooleanSelector.parse('foo')].skip, isTrue);
     });
 
     test("returns the normal metadata if forTag doesn't match tags", () {
       var metadata = new Metadata(
           verboseTrace: true,
           tags: ['bar', 'baz'],
-          forTag: {'foo': new Metadata(skip: true)});
+          forTag: {new BooleanSelector.parse('foo'): new Metadata(skip: true)});
 
       expect(metadata.verboseTrace, isTrue);
       expect(metadata.skip, isFalse);
       expect(metadata.tags, unorderedEquals(['bar', 'baz']));
-      expect(metadata.forTag, contains('foo'));
-      expect(metadata.forTag['foo'].skip, isTrue);
+      expect(metadata.forTag, contains(new BooleanSelector.parse('foo')));
+      expect(metadata.forTag[new BooleanSelector.parse('foo')].skip, isTrue);
     });
 
     test("resolves forTags that match tags", () {
       var metadata = new Metadata(
           verboseTrace: true,
           tags: ['foo', 'bar', 'baz'],
           forTag: {
-            'foo': new Metadata(skip: true),
-            'baz': new Metadata(timeout: Timeout.none),
-            'qux': new Metadata(skipReason: "blah")
+            new BooleanSelector.parse('foo'): new Metadata(skip: true),
+            new BooleanSelector.parse('baz'):
+                new Metadata(timeout: Timeout.none),
+            new BooleanSelector.parse('qux'): new Metadata(skipReason: "blah")
           });
 
       expect(metadata.verboseTrace, isTrue);
       expect(metadata.skip, isTrue);
       expect(metadata.skipReason, isNull);
       expect(metadata.timeout, equals(Timeout.none));
       expect(metadata.tags, unorderedEquals(['foo', 'bar', 'baz']));
-      expect(metadata.forTag.keys, equals(['qux']));
+      expect(metadata.forTag.keys, equals([new BooleanSelector.parse('qux')]));
     });
 
     test("resolves forTags that adds a behavioral tag", () {
       var metadata = new Metadata(
           tags: ['foo'],
           forTag: {
-            'baz': new Metadata(skip: true),
-            'bar': new Metadata(verboseTrace: true, tags: ['baz']),
-            'foo': new Metadata(tags: ['bar'])
+            new BooleanSelector.parse('baz'): new Metadata(skip: true),
+            new BooleanSelector.parse('bar'):
+                new Metadata(verboseTrace: true, tags: ['baz']),
+            new BooleanSelector.parse('foo'): new Metadata(tags: ['bar'])
           });
 
       expect(metadata.verboseTrace, isTrue);
       expect(metadata.skip, isTrue);
       expect(metadata.tags, unorderedEquals(['foo', 'bar', 'baz']));
       expect(metadata.forTag, isEmpty);
     });
 
     test("resolves forTags that adds circular tags", () {
       var metadata = new Metadata(
           tags: ['foo'],
           forTag: {
-            'foo': new Metadata(tags: ['bar']),
-            'bar': new Metadata(tags: ['baz']),
-            'baz': new Metadata(tags: ['foo'])
+            new BooleanSelector.parse('foo'): new Metadata(tags: ['bar']),
+            new BooleanSelector.parse('bar'): new Metadata(tags: ['baz']),
+            new BooleanSelector.parse('baz'): new Metadata(tags: ['foo'])
           });
 
       expect(metadata.tags, unorderedEquals(['foo', 'bar', 'baz']));
       expect(metadata.forTag, isEmpty);
     });
 
     test("base metadata takes precedence over forTags", () {
-      var metadata = new Metadata(
-          verboseTrace: true,
-          tags: ['foo'],
-          forTag: {'foo': new Metadata(verboseTrace: false)});
+      var metadata = new Metadata(verboseTrace: true, tags: ['foo'], forTag: {
+        new BooleanSelector.parse('foo'): new Metadata(verboseTrace: false)
+      });
 
       expect(metadata.verboseTrace, isTrue);
     });
   });
 
   group("onPlatform", () {
     test("parses a valid map", () {
       var metadata = new Metadata.parse(onPlatform: {
         "chrome": new Timeout.factor(2),
         "vm": [new Skip(), new Timeout.factor(3)]
@@ skipping 39 matching lines @@
       }, throwsArgumentError);
     });
 
     test("refuses multiple Skips", () {
       expect(() {
         new Metadata.parse(onPlatform: {"chrome": [new Skip(), new Skip()]});
       }, throwsArgumentError);
     });
   });
 }