Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1715583002: Remove useless CPDF_FontCharMap. (Closed)

Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com, David Lattimore
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -60 lines) Patch
M core/include/fpdfapi/fpdf_resource.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/font_int.h View 1 chunk +0 lines, -5 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 3 chunks +1 line, -47 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Lei Zhang
I started looking at this code because of cl/114898408
4 years, 10 months ago (2016-02-18 23:10:49 UTC) #2
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-18 23:14:37 UTC) #3
Lei Zhang
4 years, 10 months ago (2016-02-18 23:39:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c599b59f77d3a620e983fd30802a414795be470a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698