Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Unified Diff: components/test_runner/layout_dump.cc

Issue 1715573002: Replicating LayoutDumpFlags across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicating-pixel-dump-flag
Patch Set: Removed unneeded include. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/BUILD.gn ('k') | components/test_runner/layout_dump_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/layout_dump.cc
diff --git a/components/test_runner/layout_dump.cc b/components/test_runner/layout_dump.cc
index 3c4c84d300558542709548dd463cdf97be4f5665..bcd652b7467bc4204b2fca8c66cf31ff2bc7192d 100644
--- a/components/test_runner/layout_dump.cc
+++ b/components/test_runner/layout_dump.cc
@@ -57,9 +57,9 @@ std::string DumpLayout(WebLocalFrame* frame, const LayoutDumpFlags& flags) {
DCHECK(frame);
std::string result;
- if (flags.dump_as_text) {
+ if (flags.dump_as_text()) {
result = DumpFrameHeaderIfNeeded(frame);
- if (flags.is_printing && frame->document().isHTMLDocument()) {
+ if (flags.is_printing() && frame->document().isHTMLDocument()) {
result += WebFrameContentDumper::dumpLayoutTreeAsText(
frame, WebFrameContentDumper::LayoutAsTextPrinting)
.utf8();
@@ -67,8 +67,8 @@ std::string DumpLayout(WebLocalFrame* frame, const LayoutDumpFlags& flags) {
result += frame->document().contentAsTextForTesting().utf8();
}
result += "\n";
- } else if (flags.dump_as_markup) {
- DCHECK(!flags.is_printing);
+ } else if (flags.dump_as_markup()) {
+ DCHECK(!flags.is_printing());
result = DumpFrameHeaderIfNeeded(frame);
result += WebFrameContentDumper::dumpAsMarkup(frame).utf8();
result += "\n";
@@ -76,7 +76,7 @@ std::string DumpLayout(WebLocalFrame* frame, const LayoutDumpFlags& flags) {
if (frame->parent() == nullptr) {
WebFrameContentDumper::LayoutAsTextControls layout_text_behavior =
WebFrameContentDumper::LayoutAsTextNormal;
- if (flags.is_printing)
+ if (flags.is_printing())
layout_text_behavior |= WebFrameContentDumper::LayoutAsTextPrinting;
result = WebFrameContentDumper::dumpLayoutTreeAsText(frame,
layout_text_behavior)
« no previous file with comments | « components/test_runner/BUILD.gn ('k') | components/test_runner/layout_dump_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698