Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: components/test_runner/tracked_dictionary.h

Issue 1715573002: Replicating LayoutDumpFlags across OOPIFs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicating-pixel-dump-flag
Patch Set: Rebasing... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/tracked_dictionary.h
diff --git a/components/test_runner/tracked_dictionary.h b/components/test_runner/tracked_dictionary.h
new file mode 100644
index 0000000000000000000000000000000000000000..6257ee9ee2b9289634a3f14f7c862e991024eea4
--- /dev/null
+++ b/components/test_runner/tracked_dictionary.h
@@ -0,0 +1,55 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_TEST_RUNNER_TRACKED_DICTIONARY_H_
+#define COMPONENTS_TEST_RUNNER_TRACKED_DICTIONARY_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "components/test_runner/test_runner_export.h"
+
+namespace test_runner {
+
+class TEST_RUNNER_EXPORT TrackedDictionary {
dcheng 2016/03/08 23:09:37 Add a class comment for a summary of how this diff
Łukasz Anforowicz 2016/03/10 22:24:21 Done.
+ public:
+ TrackedDictionary();
+
+ // Current value of the tracked dictionary.
+ const base::DictionaryValue& current_values() const {
+ return current_values_;
+ }
+
+ // Subset of |current_values| that have been changed (i.e. via Set method)
+ // since the last call to ResetChangeTracking.
+ const base::DictionaryValue& changed_values() const {
+ return changed_values_;
+ }
+
+ // Clears out |changed_values|.
+ void ResetChangeTracking();
+
+ // Overwrites |current_values| with values present in |new_changes|.
+ // Application of the new values is not tracked - they will not appear in
+ // |changed_values|.
+ void ApplyUntrackedChanges(const base::DictionaryValue& new_changes);
+
+ // Sets a value in |current_values| and tracks the change in |changed_values|.
+ void Set(const std::string& path, scoped_ptr<base::Value> new_value);
+
+ // Type-specific setter for convenience.
+ void SetBoolean(const std::string& path, bool new_value);
+
+ private:
+ base::DictionaryValue current_values_;
+ base::DictionaryValue changed_values_;
+
+ DISALLOW_COPY_AND_ASSIGN(TrackedDictionary);
+};
+
+} // namespace test_runner
+
+#endif // COMPONENTS_TEST_RUNNER_TRACKED_DICTIONARY_H_

Powered by Google App Engine
This is Rietveld 408576698