Replicating LayoutDumpFlags across OOPIFs.

components/test_runner/test_runner.h

Index: components/test_runner/test_runner.h
diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h
index 1c359e7fc51d71e67d4546aa2c37bab57a679c50..b0f95d4581be2e417d802b8451daf5aca4fa954e 100644
--- a/components/test_runner/test_runner.h
+++ b/components/test_runner/test_runner.h
@@ -74,6 +74,8 @@ class TestRunner : public WebTestRunner,
   bool ShouldDumpAsAudio() const override;
   void GetAudioData(std::vector<unsigned char>* buffer_view) const override;
   const LayoutDumpFlags& GetLayoutDumpFlags() override;
+  void ReplicateLayoutDumpFlagsChanges(
+      const base::DictionaryValue& changed_values) override;
   bool HasCustomTextDump(std::string* custom_text_dump) const override;
   bool ShouldDumpBackForwardList() const override;
   blink::WebContentSettingsClient* GetWebContentSettings() const override;
@@ -621,6 +623,9 @@ class TestRunner : public WebTestRunner,
 
   void GetManifestThen(v8::Local<v8::Function> callback);
 
+  // Takes care of notifying the delegate after a change to layout dump flags.
+  void OnLayoutDumpFlagsChanged();
+
   ///////////////////////////////////////////////////////////////////////////
   // Internal helpers
 
@@ -660,9 +665,6 @@ class TestRunner : public WebTestRunner,
   // setCloseRemainingWindowsWhenComplete().
   bool close_remaining_windows_;
 
-  // If true, don't dump output until notifyDone is called.
-  bool wait_until_done_;
-
   // If true, ends the test when a URL is loaded externally via
   // WebFrameClient::loadURLExternally().
   bool wait_until_external_url_load_;
@@ -703,9 +705,6 @@ class TestRunner : public WebTestRunner,
   // command.
   bool dump_editting_callbacks_;
 
-  // If true, the test_shell will generate pixel results in DumpAsText mode
-  bool generate_pixel_results_;

[Łukasz Anforowicz, 2016/03/03 21:46:34]

I think that extra flags (i.e. policy_delegate_enabled_,
dump_frame_load_callbacks_, etc.) can be moved from TestRunner into to
LayoutDumpFlags (aka LayoutTestRuntimeFlags) in a separate CL.  This CL
arbitrarily moves 1) generate_pixel_results to showcase that it fixes a bunch of
“missing expectation” failures with --site-per-process and 2) wait_until_done_
(because otherwise extra tests start failing with --site-per-process - for
example http/tests/security/originHeader/origin-header-for-https.html).

-
   // Flags controlling what content gets dumped as a layout text result.
   LayoutDumpFlags layout_dump_flags_;