Tolerate SDKs that do not include dart:async (issue 25520)

Tolerate SDKs that do not include dart:async (issue 25520)

R=danrubel@google.com

Committed: https://github.com/dart-lang/sdk/commit/bfacd1878ccf447ff25057ebd4e950915c7c3ced

[Brian Wilkerson, 2016-02-18 22:06:44]

brianwilkerson@google.com changed reviewers:
+ danrubel@google.com

[Brian Wilkerson, 2016-02-18 22:06:44]

I don't know how to test this easily; maybe you could confirm (or suggest an
approach).

[danrubel, 2016-02-18 22:49:47]

On 2016/02/18 22:06:44, Brian Wilkerson wrote:
> I don't know how to test this easily; maybe you could confirm (or suggest an
> approach).

Fix the MockSdk # mapDartUri method in
pkg/analyzer/test/src/context/mock_sdk.dart so that it returns null for
'dart:async' if the MockSdk was instantiated with dartAsync:false. Once that's
done, the BuildTypeProviderTaskTest_noAsync test will correctly fail without
your patch rather than incorrectly passing as it does now.

[Brian Wilkerson, 2016-02-18 23:14:58]

Test added. Confirmed failure without the fix and passing after the fix.

[danrubel, 2016-02-19 02:22:15]

LGTM. Thanks!

[Brian Wilkerson, 2016-02-19 15:45:55]

Description was changed from

==========
Tolerate SDKs that do not include dart:async (issue 25520)
==========

to

==========
Tolerate SDKs that do not include dart:async (issue 25520)

R=danrubel@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bfacd1878ccf447ff25057ebd4e950915c7c3ced
==========

[Brian Wilkerson, 2016-02-19 15:45:57]

Committed patchset #2 (id:20001) manually as
bfacd1878ccf447ff25057ebd4e950915c7c3ced (presubmit successful).