third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp - Issue 1715513002: Move background related shorthands into CSSPropertyParser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

Issue 1715513002: Move background related shorthands into CSSPropertyParser (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

index aedbb41c1b1a99a7745f9df2d93ec968913b6867..d2706527c7378776d428b89d374b5ae405b392c5 100644

--- a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp

@@ -222,7 +222,7 @@ void CSSToStyleMap::mapFillXPosition(StyleResolverState& state, FillLayer* layer

if (value.isValuePair())

length = toCSSPrimitiveValue(toCSSValuePair(value).second()).convertToLength(state.cssToLengthConversionData());

else

- length = toCSSPrimitiveValue(value).convertToLength(state.cssToLengthConversionData());

+ length = StyleBuilderConverter::convertPositionLength<CSSValueLeft, CSSValueRight>(state, toCSSPrimitiveValue(value));

layer->setXPosition(length);

if (value.isValuePair())

@@ -243,7 +243,7 @@ void CSSToStyleMap::mapFillYPosition(StyleResolverState& state, FillLayer* layer

if (value.isValuePair())

length = toCSSPrimitiveValue(toCSSValuePair(value).second()).convertToLength(state.cssToLengthConversionData());

else

- length = toCSSPrimitiveValue(value).convertToLength(state.cssToLengthConversionData());

+ length = StyleBuilderConverter::convertPositionLength<CSSValueTop, CSSValueBottom>(state, toCSSPrimitiveValue(value));

layer->setYPosition(length);

if (value.isValuePair())