Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1715503004: added /enableGPU command to skiaserve (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
jcgregorio, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : now defaults to CPU and raises an error if GPU surface cannot be created #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -24 lines) Patch
M tools/skiaserve/skiaserve.cpp View 1 8 chunks +70 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ethannicholas
4 years, 10 months ago (2016-02-19 15:17:48 UTC) #3
jcgregorio
https://codereview.chromium.org/1715503004/diff/1/tools/skiaserve/skiaserve.cpp File tools/skiaserve/skiaserve.cpp (right): https://codereview.chromium.org/1715503004/diff/1/tools/skiaserve/skiaserve.cpp#newcode175 tools/skiaserve/skiaserve.cpp:175: SkASSERT(surface); Instead of asserting how about checking for a ...
4 years, 10 months ago (2016-02-19 15:23:56 UTC) #4
ethannicholas
Updated in response to Joe's feedback.
4 years, 10 months ago (2016-02-19 16:12:13 UTC) #5
jcgregorio
lgtm
4 years, 10 months ago (2016-02-19 16:14:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715503004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715503004/20001
4 years, 10 months ago (2016-02-19 16:15:03 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 16:41:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/85fca851e621d18db9b0cb5dc47878a77310ef15

Powered by Google App Engine
This is Rietveld 408576698