Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 17155024: CSS clip property should not force additional clamping to border box (Closed)

Created:
7 years, 6 months ago by shawnsingh
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, esprehn
Visibility:
Public.

Description

CSS clip property should not force additional clamping to border box For a composited layer computing its bounds, there is a code path that clamps a layer's cliprect to the corresponding element's border box. However, this is incorrect, since a CSS clip may have valid bounds that include things outside the border box. So, that clamping should only occur if there is an overflow clip. BUG=246728 R=jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152919

Patch Set 1 #

Patch Set 2 : fixed linux/win rebaselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M LayoutTests/compositing/geometry/clip-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/focus-ring-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/repaint/layer-outline-expected.txt View 1 chunk +6 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/layer-outline-horizontal-expected.txt View 1 chunk +6 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/repaint/layer-outline-expected.txt View 1 1 chunk +6 lines, -2 lines 0 comments Download
M LayoutTests/platform/chromium-win/fast/repaint/layer-outline-horizontal-expected.txt View 1 1 chunk +6 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
shawnsingh
PTAL. This patch is covered by the existing test, compositing/geometry/clip.html, which previously had an incorrect ...
7 years, 6 months ago (2013-06-21 22:37:26 UTC) #1
Julien - ping for review
lgtm, assuming the bots are passing.
7 years, 6 months ago (2013-06-21 23:47:14 UTC) #2
shawnsingh
7 years, 6 months ago (2013-06-22 04:24:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r152919 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698