Issue 17155019: Fix file permissions for https://chromiumcodereview.appspot.com/17112021

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17155019: Fix file permissions for https://chromiumcodereview.appspot.com/17112021 (Closed)

Created:
7 years, 6 months ago by rmsousa

Modified:
7 years, 6 months ago

Reviewers:
Yuki

CC:
chromium-reviews, nona+watch_chromium.org, James Su, tfarina, penghuang+watch_chromium.org, yusukes+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix file permissions for https://chromiumcodereview.appspot.com/17112021 TBR=yukishiino@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207916

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs			Patch
A	ui/base/ime/dummy_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/dummy_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/fake_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/fake_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_ibus.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_ibus.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_imm32.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_imm32.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_tsf.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/input_method_tsf.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/mock_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/base/ime/mock_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/input_method_bridge.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/input_method_bridge.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/input_method_win.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/input_method_win.cc	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/mock_input_method.h	View	+-1 lines, --1 lines	0 comments	Download
A	ui/views/ime/mock_input_method.cc	View	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rmsousa

Committed patchset #1 manually as r207916 (presubmit successful).

7 years, 6 months ago (2013-06-21 20:41:10 UTC) #1

Yuki

7 years, 6 months ago (2013-06-22 05:09:26 UTC) #2

Message was sent while issue was closed.

LGTM.

Thanks for  the fix, and sorry for the careless mistake.

Expand Messages | Collapse Messages