Issue 17155014: API for DataView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17155014: API for DataView. (Closed)

Created:
7 years, 6 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 6 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

API for DataView. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15282

Patch Set 1 #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+260 lines, -113 lines)			Patch
M	include/v8.h	View	6 chunks	+72 lines, -10 lines	0 comments	Download
M	src/api.h	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	src/api.cc	View	8 chunks	+80 lines, -38 lines	1 comment	Download
M	test/cctest/test-api.cc	View	7 chunks	+77 lines, -47 lines	0 comments	Download
M	test/cctest/test-weaktypedarrays.cc	View	5 chunks	+23 lines, -18 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

lgtm https://codereview.chromium.org/17155014/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/17155014/diff/1/src/api.cc#newcode6389 src/api.cc:6389: LOG_API(isolate, "v8::DataView::New(void*, size_t. size_t)"); Nit: comma instead of ...

7 years, 6 months ago (2013-06-24 08:17:54 UTC) #2

Dmitry Lomov (no reviews)

7 years, 6 months ago (2013-06-24 11:23:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15282 (presubmit successful).

Expand Messages | Collapse Messages