Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 17155010: Use type feedback for Array (non-constructor) call sites. (Closed)

Created:
7 years, 6 months ago by mvstanton
Modified:
7 years, 6 months ago
Reviewers:
danno, Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Use type feedback for Array (non-constructor) call sites. BUG= R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15201

Patch Set 1 #

Patch Set 2 : Ports to platforms #

Patch Set 3 : Added test, minor fix #

Patch Set 4 : Nit fixin' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -70 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 16 chunks +73 lines, -16 lines 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 1 chunk +9 lines, -1 line 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 16 chunks +71 lines, -16 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.h View 3 chunks +11 lines, -3 lines 0 comments Download
M src/stub-cache.cc View 4 chunks +23 lines, -4 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 15 chunks +70 lines, -15 lines 0 comments Download
A + test/mjsunit/array-feedback.js View 1 2 3 1 chunk +128 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi guys, Here is the code Toon and I worked on. I'd like to add ...
7 years, 6 months ago (2013-06-18 15:59:18 UTC) #1
Toon Verwaest
Looking good. Waiting for tests.
7 years, 6 months ago (2013-06-19 08:48:55 UTC) #2
Toon Verwaest
lgtm
7 years, 6 months ago (2013-06-19 09:22:45 UTC) #3
mvstanton
7 years, 6 months ago (2013-06-19 09:25:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r15201 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698