Source/core/css/CSSParser-in.cpp - Issue 17155007: [CSS3] Parsing the property, text-justify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSParser-in.cpp

Issue 17155007: [CSS3] Parsing the property, text-justify. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@parsingTextJustify

Patch Set: Modify the test case Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css3-text/css3-text-justify/getComputedStyle/getComputedStyle-text-justify.html ('K') | « Source/core/css/CSSComputedStyleDeclaration.cpp ('k') | Source/core/css/CSSPrimitiveValueMappings.h » ('j') | Source/core/css/CSSValueKeywords.in » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSParser-in.cpp

diff --git a/Source/core/css/CSSParser-in.cpp b/Source/core/css/CSSParser-in.cpp

index 1b84bdac8a4396efd0e84ec9a1eca63928cb5eaf..77fc6cf00c10465e5cc4fcb4f85b97098df13824 100644

--- a/Source/core/css/CSSParser-in.cpp

+++ b/Source/core/css/CSSParser-in.cpp

@@ -708,6 +708,12 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int

&& ((valueID >= CSSValueLeft && valueID <= CSSValueJustify) || valueID == CSSValueStart || valueID == CSSValueEnd || valueID == CSSValueAuto))

return true;

break;

+ case CSSPropertyTextJustify:

+ // auto | none | inter-word | distribute

+ if (RuntimeEnabledFeatures::css3TextEnabled()

+ && (valueID == CSSValueInterWord || valueID == CSSValueDistribute || valueID == CSSValueAuto || valueID == CSSValueNone))

+ return true;

+ break;

case CSSPropertyTextLineThroughMode:

case CSSPropertyTextOverlineMode:

case CSSPropertyTextUnderlineMode:

@@ -950,8 +956,6 @@ static inline bool isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyMixBlendMode:

case CSSPropertyIsolation:

return RuntimeEnabledFeatures::cssCompositingEnabled();

- case CSSPropertyTextAlignLast:

- return RuntimeEnabledFeatures::css3TextEnabled();

case CSSPropertyBorderBottomStyle:

case CSSPropertyBorderCollapse:

case CSSPropertyBorderLeftStyle:

@@ -981,6 +985,8 @@ static inline bool isKeywordPropertyID(CSSPropertyID propertyId)

case CSSPropertyResize:

case CSSPropertySpeak:

case CSSPropertyTableLayout:

+ case CSSPropertyTextAlignLast:

+ case CSSPropertyTextJustify:

case CSSPropertyTextLineThroughMode:

case CSSPropertyTextLineThroughStyle:

case CSSPropertyTextOverflow:

@@ -2829,6 +2835,7 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)

case CSSPropertySpeak:

case CSSPropertyTableLayout:

case CSSPropertyTextAlignLast:

+ case CSSPropertyTextJustify:

case CSSPropertyTextLineThroughMode:

case CSSPropertyTextLineThroughStyle:

case CSSPropertyTextOverflow: