[CSS3] Parsing the property, text-justify.

Source/core/css/CSSParser-in.cpp

Index: Source/core/css/CSSParser-in.cpp
diff --git a/Source/core/css/CSSParser-in.cpp b/Source/core/css/CSSParser-in.cpp
index 4bdef93550d310d97da145d0a73d885479fa2a0d..a9899071b9f544369bcb6c6f35f399266bf74b9d 100644
--- a/Source/core/css/CSSParser-in.cpp
+++ b/Source/core/css/CSSParser-in.cpp
@@ -692,6 +692,12 @@ static inline bool isValidKeywordPropertyAndValue(CSSPropertyID propertyId, int
             && ((valueID >= CSSValueLeft && valueID <= CSSValueJustify) || valueID == CSSValueStart || valueID == CSSValueEnd || valueID == CSSValueAuto))
             return true;
         break;
+    case CSSPropertyTextJustify:
+        // auto | none | inter-word | distribute
+        if (RuntimeEnabledFeatures::css3TextEnabled()
+            && (valueID == CSSValueInterWord || valueID == CSSValueDistribute || valueID == CSSValueAuto || valueID == CSSValueNone))
+            return true;
+        break;
     case CSSPropertyTextLineThroughMode:
     case CSSPropertyTextOverlineMode:
     case CSSPropertyTextUnderlineMode:
@@ -929,6 +935,7 @@ static inline bool isKeywordPropertyID(CSSPropertyID propertyId)
     case CSSPropertyMixBlendMode:
         return RuntimeEnabledFeatures::cssCompositingEnabled();
     case CSSPropertyTextAlignLast:
+    case CSSPropertyTextJustify:
         return RuntimeEnabledFeatures::css3TextEnabled();

[Julien - ping for review, 2013/07/15 22:05:47]

I don't think this logic is OK. In debug, we will hit the ASSERT if CSS3 text is
disabled. This should just always return true and the runtime flag check above
would reject the properties.

[dw.im, 2013/07/16 01:13:56]

Then, I think TextAlignLast is also needed to return true always, isn't it?

[Julien - ping for review, 2013/07/16 19:40:09]

Right, you need to return false when the flag is off but that's a small change.
You can always check how the other runtime enabled features work (e.g. grid
layout or region).

     case CSSPropertyBorderBottomStyle:
     case CSSPropertyBorderCollapse:
@@ -2765,6 +2772,7 @@ bool CSSParser::parseValue(CSSPropertyID propId, bool important)
     case CSSPropertySpeak:
     case CSSPropertyTableLayout:
     case CSSPropertyTextAlignLast:
+    case CSSPropertyTextJustify:
     case CSSPropertyTextLineThroughMode:
     case CSSPropertyTextLineThroughStyle:
     case CSSPropertyTextOverflow: