tools/debugger/SkDrawCommand.cpp - Issue 1715443002: fixed SkDrawCommand JSON generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/debugger/SkDrawCommand.cpp

Issue 1715443002: fixed SkDrawCommand JSON generation (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/debugger/SkDrawCommand.cpp

diff --git a/tools/debugger/SkDrawCommand.cpp b/tools/debugger/SkDrawCommand.cpp

index 674a359cbbc4e0d21ae5ae7c3625f0c2fc0750a3..b46e4925a3b25cf968485d460f493d7f368802f2 100644

--- a/tools/debugger/SkDrawCommand.cpp

+++ b/tools/debugger/SkDrawCommand.cpp

@@ -227,8 +227,7 @@ Json::Value SkDrawCommand::toJSON(UrlDataManager& urlDataManager) const {

Json::Value SkDrawCommand::drawToAndCollectJSON(SkCanvas* canvas,

UrlDataManager& urlDataManager) const {

- Json::Value result;

- result[SKDEBUGCANVAS_ATTRIBUTE_COMMAND] = this->GetCommandString(fOpType);

+ Json::Value result = this->toJSON(urlDataManager);

SkASSERT(canvas);

« no previous file with comments | « no previous file | no next file » | no next file with comments »