Issue 1715363002: Fix a crasher in ParsePostfixExpression()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1715363002: Fix a crasher in ParsePostfixExpression() (Closed)

Created:
4 years, 10 months ago by jun_fang

Modified:
4 years, 10 months ago

Reviewers:
Tom Sepez, Lei Zhang

CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix a crasher in ParsePostfixExpression() BUG=pdfium:409 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bd7820c536908801e49ea83a6ca73279cc07f5cd

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -7 lines)			Patch
	M	xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp	View		2 chunks	+5 lines, -7 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jun_fang

Hi Tom and Lei, Please start to review this CL. Thanks!

4 years, 10 months ago (2016-02-22 09:50:04 UTC) #2

Tom Sepez

lgtm https://codereview.chromium.org/1715363002/diff/1/xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp File xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp (right): https://codereview.chromium.org/1715363002/diff/1/xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp#newcode603 xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp:603: e = 0; nit: nullptr here too?

4 years, 10 months ago (2016-02-22 17:15:07 UTC) #3

jun_fang

4 years, 10 months ago (2016-02-23 00:32:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bd7820c536908801e49ea83a6ca73279cc07f5cd (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages