Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1715363002: Fix a crasher in ParsePostfixExpression() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp View 2 chunks +5 lines, -7 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
jun_fang
Hi Tom and Lei, Please start to review this CL. Thanks!
4 years, 10 months ago (2016-02-22 09:50:04 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1715363002/diff/1/xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp File xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp (right): https://codereview.chromium.org/1715363002/diff/1/xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp#newcode603 xfa/src/fxfa/src/fm2js/xfa_fmparse.cpp:603: e = 0; nit: nullptr here too?
4 years, 10 months ago (2016-02-22 17:15:07 UTC) #3
jun_fang
4 years, 10 months ago (2016-02-23 00:32:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd7820c536908801e49ea83a6ca73279cc07f5cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698