chrome/browser/resources/inline_login/inline_login.js - Issue 171533014: Revert of Implement inline signin with iframe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/inline_login/inline_login.js

Issue 171533014: Revert of Implement inline signin with iframe (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/inline_login/inline_login.js

diff --git a/chrome/browser/resources/inline_login/inline_login.js b/chrome/browser/resources/inline_login/inline_login.js

index 6e09bb612258ff9c9e192d1abf28acb59a679df9..fbd30c907ddc5da215a84ecb3c850c2d20eac613 100644

--- a/chrome/browser/resources/inline_login/inline_login.js

+++ b/chrome/browser/resources/inline_login/inline_login.js

@@ -49,7 +49,10 @@

function loadAuthExtension(data) {

authExtHost.load(data.authMode, data, onAuthCompleted);

- $('contents').classList.toggle('loading', true);

+ // Do not show loading spinner to give user a faster response

+ // with inline flows.

+ $('contents').classList.toggle('loading',

+ data.authMode != cr.login.GaiaAuthHost.AuthMode.INLINE);

}

/**