Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 171533011: Move Android-specific xml files to remoting/resources/android/ (Closed)

Created:
6 years, 10 months ago by Lambros
Modified:
6 years, 10 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Move Android-specific xml files to remoting/resources/android/ Also added copyright notices to these files. strings.xml has been moved to a values/ directory for consistency, although we ultimately want to get rid of that file. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252247

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -157 lines) Patch
M remoting/remoting_android.gypi View 1 chunk +7 lines, -7 lines 0 comments Download
A + remoting/resources/android/layout/desktop.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/resources/android/layout/host.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A + remoting/resources/android/layout/main.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A + remoting/resources/android/layout/pin_dialog.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A + remoting/resources/android/menu/chromoting_actionbar.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A + remoting/resources/android/menu/desktop_actionbar.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A + remoting/resources/android/values/strings.xml View 1 chunk +6 lines, -0 lines 0 comments Download
D remoting/resources/layout/desktop.xml View 1 chunk +0 lines, -22 lines 0 comments Download
D remoting/resources/layout/host.xml View 1 chunk +0 lines, -9 lines 0 comments Download
D remoting/resources/layout/main.xml View 1 chunk +0 lines, -12 lines 0 comments Download
D remoting/resources/layout/pin_dialog.xml View 1 chunk +0 lines, -15 lines 0 comments Download
D remoting/resources/menu/chromoting_actionbar.xml View 1 chunk +0 lines, -12 lines 0 comments Download
D remoting/resources/menu/desktop_actionbar.xml View 1 chunk +0 lines, -18 lines 0 comments Download
D remoting/resources/strings.xml View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Lambros
This addresses some of Sergey's comments from https://codereview.chromium.org/165743002/ but I decided to do this cleanup ...
6 years, 10 months ago (2014-02-19 21:45:17 UTC) #1
Jamie
lgtm
6 years, 10 months ago (2014-02-19 21:51:55 UTC) #2
Lambros
The CQ bit was checked by lambroslambrou@chromium.org
6 years, 10 months ago (2014-02-20 00:08:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/171533011/1
6 years, 10 months ago (2014-02-20 01:21:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/171533011/1
6 years, 10 months ago (2014-02-20 05:09:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/171533011/1
6 years, 10 months ago (2014-02-20 09:05:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/171533011/1
6 years, 10 months ago (2014-02-20 12:27:57 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 15:55:09 UTC) #8
Message was sent while issue was closed. 
Change committed as 252247

Powered by Google App Engine
This is Rietveld 408576698