Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/LayoutTests/media/video-volume.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-volume.html
diff --git a/third_party/WebKit/LayoutTests/media/video-volume.html b/third_party/WebKit/LayoutTests/media/video-volume.html
index 82e6937c71fc63e08d6a73a991c829de7843c3fe..c63b81ba3cccffbd86c2455df62c0a7884257ce6 100644
--- a/third_party/WebKit/LayoutTests/media/video-volume.html
+++ b/third_party/WebKit/LayoutTests/media/video-volume.html
@@ -1,6 +1,8 @@
<video controls></video>
<p>Test 'volume' attribute<p>
<script src=media-file.js></script>
+<!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script>
testExpected("video.volume", 1.0);
@@ -24,5 +26,5 @@
testDOMException("video.volume = 1.5", "DOMException.INDEX_SIZE_ERR");
testDOMException("video.volume = -0.5", "DOMException.INDEX_SIZE_ERR");
endTest();
- });
+ });
</script>

Powered by Google App Engine
This is Rietveld 408576698