Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/WebKit/LayoutTests/media/video-src.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-src.html
diff --git a/third_party/WebKit/LayoutTests/media/video-src.html b/third_party/WebKit/LayoutTests/media/video-src.html
index bda4c15df814f796f5bba0834786773ecb2a2b22..0d460efb5176ed16e5c269a963bf5ec9c0a022d4 100644
--- a/third_party/WebKit/LayoutTests/media/video-src.html
+++ b/third_party/WebKit/LayoutTests/media/video-src.html
@@ -1,6 +1,8 @@
<html>
<head>
<script src=media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script>
@@ -8,14 +10,14 @@
{
video = mediaElement = document.getElementsByTagName('video')[0];
var mediaFile = findMediaFile("video", "content/test");
-
+
waitForEvent("loadstart", function () {
testExpected("stripExtension(relativeURL(video.currentSrc))", stripExtension(mediaFile));
testExpected("stripExtension(relativeURL(video.src))", stripExtension(mediaFile));
testExpected("stripExtension(video.getAttribute('src'))", stripExtension(mediaFile));
endTest();
});
-
+
video.src = mediaFile;
}
</script>
@@ -25,4 +27,3 @@
<video controls></video>
</body>
</html>
-

Powered by Google App Engine
This is Rietveld 408576698