third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-src-invalid-poster.html ('k') | third_party/WebKit/LayoutTests/media/video-src-none.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html

diff --git a/third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html b/third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html

index 88fe9ffa8e1578904616cca6348553def612a2da..c7d4171521cdd866a90ff618c6e8a35dcd51cbb4 100644

--- a/third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html

+++ b/third_party/WebKit/LayoutTests/media/video-src-invalid-remove.html

@@ -1,28 +1,30 @@

<html>

<head>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

function loadedmetadata()

{

failTest(relativeURL(video.currentSrc) + "loaded but should not" );

consoleWrite("");

}

function errorEvent()

{

testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED);

// "setTimeout()" is generally bad form in a layout test, but we need to verify

- // that changing the 'src' attribute does not do something that happens

+ // that changing the 'src' attribute does not do something that happens

// asynchronously so we don't have a lot of options.

setTimeout(function () { endTest(); }, 200) ;

run("video.removeAttribute('src')");

consoleWrite("");

}

function setup()

{

findMediaElement();

@@ -47,7 +49,7 @@

<p>Test that removing 'src' attribute does NOT trigger load of <source> elements</p>

</script>

</body>