third_party/WebKit/LayoutTests/media/video-src-change.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-src-change.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-src-blob.html ('k') | third_party/WebKit/LayoutTests/media/video-src-empty.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-src-change.html

diff --git a/third_party/WebKit/LayoutTests/media/video-src-change.html b/third_party/WebKit/LayoutTests/media/video-src-change.html

index 7ad40bec30c0f98734f9945ca2c0a2aa01918991..624ce21b3ad0ae8a4ca096085730ce0a0e2a142a 100644

--- a/third_party/WebKit/LayoutTests/media/video-src-change.html

+++ b/third_party/WebKit/LayoutTests/media/video-src-change.html

@@ -1,12 +1,14 @@

<html>

<head>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

var mediaFile;

var loadedCount = 0;

var errorCount = 0;

function errorEvent()

{

testExpected("relativeURL(video.currentSrc)", "bogus");

@@ -21,13 +23,13 @@

setSrcAttribure(findMediaFile("video", "content/test"));

consoleWrite("");

}

function loadedmetadata()

{

testExpected("stripExtension(relativeURL(video.currentSrc))", stripExtension(mediaFile));

testExpected("isNaN(video.duration)", false);

consoleWrite("");

if (++loadedCount >= 2) {

mediaElement.removeEventListener('loadedmetadata', loadedmetadata);

endTest();

@@ -37,13 +39,13 @@

setSrcAttribure(findMediaFile("video", "content/counting"));

consoleWrite("");

}

function setSrcAttribure(src)

{

mediaFile = src;

video.setAttribute('src', src);

}

function setup()

{

findMediaElement();

@@ -56,7 +58,7 @@

</head>

<p>