Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/LayoutTests/media/video-played-collapse.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-played-collapse.html
diff --git a/third_party/WebKit/LayoutTests/media/video-played-collapse.html b/third_party/WebKit/LayoutTests/media/video-played-collapse.html
index 32735e99f869ab39a3c255b61e0306eec75c0fdc..46885341f33f96cd5ae432b91cbe015cc554c4a5 100644
--- a/third_party/WebKit/LayoutTests/media/video-played-collapse.html
+++ b/third_party/WebKit/LayoutTests/media/video-played-collapse.html
@@ -2,22 +2,24 @@
<head>
<title>Test of 'played' attribute</title>
<script src=media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script src=video-played.js></script>
<script>
-
- var testFunctions =
- [
+
+ var testFunctions =
+ [
PlayWithNoRanges,
CreateANewRange,
JumpAndCollapseTwoRanges,
TestLoopingAndPassToTheEnd
];
-
+
// NOTE: Result details are not printed for this test because time values are different from machine
// to machine and run to run. Commenting out the following line turns on detailed logging back on, which
// can be useful for debugging test failure.
- disableFullTestDetailsPrinting();
+ disableFullTestDetailsPrinting();
function PlayWithNoRanges()
{
@@ -32,12 +34,12 @@
currentTimeRange++;
startPlayingInNewRange();
}
-
+
function CreateANewRange()
{
consoleWrite("<br><b><em>Create a new range</em></b>");
-
+
var newTime = (video.played.end(0) + 0.05).toFixed(2);
runSilently("video.currentTime = " + newTime);
@@ -50,7 +52,7 @@
function JumpAndCollapseTwoRanges()
{
consoleWrite("<br><b><em>Test playing from one range into another, should collapse the two ranges</em></b>");
-
+
timeRangeCount--;
currentTimeRange = timeRangeCount - 1;
var startTime = expectedStartTimes[0] - 0.1;
@@ -72,9 +74,9 @@
run("video.loop = true");
var startTime = (video.duration - 0.05).toFixed(2);
runSilently("video.currentTime = " + startTime);
-
+
// We will end in the very first time range
- currentTimeRange = 0;
+ currentTimeRange = 0;
willPauseInExistingRange = true;
willExtendAnExistingRange = true;

Powered by Google App Engine
This is Rietveld 408576698