third_party/WebKit/LayoutTests/media/video-loop.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-loop.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-load-readyState.html ('k') | third_party/WebKit/LayoutTests/media/video-loop-from-ended.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-loop.html

diff --git a/third_party/WebKit/LayoutTests/media/video-loop.html b/third_party/WebKit/LayoutTests/media/video-loop.html

index 4e44416754b58ee0508ab8abe7788dd0ffd2da00..dafcfc99c1bf13087f9d1dfd0bdb58ddc5e27c0d 100644

--- a/third_party/WebKit/LayoutTests/media/video-loop.html

+++ b/third_party/WebKit/LayoutTests/media/video-loop.html

@@ -2,12 +2,14 @@

<html>

<head>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

var seekCount = 0;

var playCount = 0;

function play()

{

if (video.readyState < HTMLMediaElement.HAVE_METADATA) {

@@ -20,14 +22,14 @@

consoleWrite("<br><em>++ seek to near the end, wait for 'seeked' event to announce loop.</em>");

testExpected("video.paused", false);

// Pause playback so the movie can't possibly loop before the seeked event fires

run("video.pause()");

waitForEvent("seeked", seeked);

run("video.currentTime = video.duration - 0.4");

consoleWrite("");

}

function seeked()

{

switch (++seekCount)

@@ -46,7 +48,7 @@

run("video.pause()");

testExpected("mediaElement.currentTime", 0, '>=');

// don't use "testExpected()" so we won't log the actual duration as the floating point result may differ with different engines

reportExpected(mediaElement.currentTime < mediaElement.duration, "mediaElement.currentTime", "<", "mediaElement.duration", mediaElement.currentTime);

run("video.loop = false");

@@ -63,11 +65,11 @@

default:

failTest("Video should have only seeked three times.");

break;

}

- function ended()

+ function ended()

{

consoleWrite("<br><em>++ played to end and stopped.</em>");

testExpected("video.ended", true);

@@ -78,7 +80,7 @@

consoleWrite("");

endTest();

}

function start()

{

findMediaElement();

@@ -86,14 +88,14 @@

consoleWrite("<em>++ Test setting/removing the attribute.</em>");

testExpected("video.getAttribute('loop')", null);

testExpected("video.loop", false);

run("video.loop = true");

testExpected("video.loop", true);

testExpected("video.getAttribute('loop')", null, "!=");

run("video.removeAttribute('loop')");

testExpected("video.loop", false);

waitForEvent('pause');

waitForEvent('play', play);

waitForEvent("ended", ended);