Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/LayoutTests/media/video-load-networkState.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-load-networkState.html
diff --git a/third_party/WebKit/LayoutTests/media/video-load-networkState.html b/third_party/WebKit/LayoutTests/media/video-load-networkState.html
index eee64ac8ac51df5091df526748dc826d6dac718e..bcd7e95d29fc91614aee50b1b058ef16623e0300 100644
--- a/third_party/WebKit/LayoutTests/media/video-load-networkState.html
+++ b/third_party/WebKit/LayoutTests/media/video-load-networkState.html
@@ -7,8 +7,10 @@
to NETWORK_NO_SOURCE. Setting src to a valid url should then trigger the loading
events and end up with networkState >= NETWORK_LOADING.
</p>
-
+
<script src=media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script>
function testNetworkState(expected, endit, op)
@@ -17,7 +19,7 @@
if (endit)
endTest();
}
-
+
waitForEvent("loadstart");
waitForEvent("loadedmetadata");
waitForEvent("loadeddata");
@@ -25,14 +27,14 @@
waitForEventAndFail("play");
waitForEventAndFail("playing");
waitForEvent("canplaythrough", function () { testNetworkState(HTMLMediaElement.NETWORK_IDLE, true, '>=' ); } );
-
+
function waitUntilNotLoading()
{
if (video.networkState == HTMLMediaElement.NETWORK_LOADING) {
setTimeout(waitUntilNotLoading, 100);
return;
}
-
+
testNetworkState(HTMLMediaElement.NETWORK_NO_SOURCE);
consoleWrite("");
@@ -42,7 +44,7 @@
runSilently("video.src = '" + mediaFile + "'");
enableFullTestDetailsPrinting();
}
-
+
// first set the src to a bogus url, it should attempt a load
consoleWrite("");
testNetworkState(HTMLMediaElement.NETWORK_EMPTY);

Powered by Google App Engine
This is Rietveld 408576698