Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/LayoutTests/media/video-dom-src.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-dom-src.html
diff --git a/third_party/WebKit/LayoutTests/media/video-dom-src.html b/third_party/WebKit/LayoutTests/media/video-dom-src.html
index 0abdf7e0c131795ffcd1740940569866fcdd82c9..2b681cf2c06d741af535c09844db4a3588a07b67 100644
--- a/third_party/WebKit/LayoutTests/media/video-dom-src.html
+++ b/third_party/WebKit/LayoutTests/media/video-dom-src.html
@@ -1,5 +1,7 @@
<video controls></video>
<script src=media-file.js></script>
+<!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script>
testExpected("video.currentSrc", "");
@@ -7,10 +9,10 @@
video.src = mediaFile;
testExpected("video.currentSrc", "");
- waitForEvent('canplaythrough', function () {
+ waitForEvent('canplaythrough', function () {
testExpected("stripExtension(relativeURL(video.currentSrc))", stripExtension(mediaFile));
endTest();
} );
-
+
video.load();
</script>

Powered by Google App Engine
This is Rietveld 408576698