Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: third_party/WebKit/LayoutTests/media/video-defaultmuted.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-defaultmuted.html
diff --git a/third_party/WebKit/LayoutTests/media/video-defaultmuted.html b/third_party/WebKit/LayoutTests/media/video-defaultmuted.html
index 931c0a2fff5ad92cae351216e4ae85c4039629b4..381c94ac579b577930025d0559c3619878bbc440 100644
--- a/third_party/WebKit/LayoutTests/media/video-defaultmuted.html
+++ b/third_party/WebKit/LayoutTests/media/video-defaultmuted.html
@@ -1,6 +1,8 @@
<!doctype html>
<html>
<head>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script src=media-file.js></script>
<script>
@@ -38,7 +40,7 @@
run("video.defaultMuted = " + newDefaultMuted);
testMuted(defaultMuted, newDefaultMuted);
testExpected("video.hasAttribute('muted')", newDefaultMuted);
-
+
consoleWrite("<br>*** Change 'muted' IDL attribute, content attribute should not change");
run("video.muted = false");
testMuted(false, newDefaultMuted);

Powered by Google App Engine
This is Rietveld 408576698