third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-mouse-after-touch.html ('k') | third_party/WebKit/LayoutTests/media/video-controls-visible-exiting-fullscreen.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html

diff --git a/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html b/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html

index a4296584a582f6d2cf6c026d5036d6d607bf7078..3ed390ae36f8d430abf949d4ab10fe95367d1a80 100644

--- a/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html

+++ b/third_party/WebKit/LayoutTests/media/video-controls-visibility-multimodal-touch-after-mouse.html

@@ -6,6 +6,8 @@

height: 240px;

}

</style>

+<!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

@@ -28,7 +30,7 @@ function runTest()

// Hover the control with the mouse.

var coords = mediaControlsButtonCoordinates(video, "play-button");

eventSender.mouseMoveTo(coords[0], coords[1]);

// And then tap (touch input) the play button.

eventSender.gestureTapDown(coords[0], coords[1]);

eventSender.gestureShowPress(coords[0], coords[1]);

@@ -48,7 +50,7 @@ function runTest()

testExpected("getComputedStyle(controls).opacity", 0);

endTest();

}, video);

}

</script>

<body>