Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
diff --git a/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html b/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
index 935660c2c43801ce66361c276998224c9f2793a3..48cb5828f33e5ba5b952f8d41d254cf660d5eebc 100644
--- a/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
+++ b/third_party/WebKit/LayoutTests/media/video-controls-auto-hide-after-play-by-touch.html
@@ -6,6 +6,8 @@
height: 240px;
}
</style>
+<!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script src=media-file.js></script>
<script src=media-controls.js></script>
@@ -17,7 +19,7 @@ function dispatchActivateEvent(target) {
// Create a DOMActivate event and dispatch it
var event = document.createEvent('UIEvents');
event.initUIEvent('DOMActivate', true, true, window, 1)
- target.dispatchEvent(event);
+ target.dispatchEvent(event);
}
@@ -37,7 +39,7 @@ function runTest()
eventSender.gestureTap(clickX, clickY);
eventSender.gestureTapDown(clickX, clickY);
dispatchActivateEvent(controls);
-
+
testExpected("video.paused", false);
runAfterHideMediaControlsTimerFired(function()

Powered by Google App Engine
This is Rietveld 408576698