third_party/WebKit/LayoutTests/media/video-canvas.html-disabled - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/video-canvas.html-disabled

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-buffered-unknown-duration.html ('k') | third_party/WebKit/LayoutTests/media/video-canvas-source.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/video-canvas.html-disabled

diff --git a/third_party/WebKit/LayoutTests/media/video-canvas.html-disabled b/third_party/WebKit/LayoutTests/media/video-canvas.html-disabled

index 8dce0cedd762a6d6b5796d9656c810b706046889..31ea5f4bab22a849154e66d58ba52bceeccde5dc 100644

--- a/third_party/WebKit/LayoutTests/media/video-canvas.html-disabled

+++ b/third_party/WebKit/LayoutTests/media/video-canvas.html-disabled

@@ -1,6 +1,8 @@

<html>

<head>

<title>drawing <video> to <canvas></title>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

@@ -23,7 +25,7 @@

function testPixel()

{

var expected = results.values[results.current];

- if (expected.time)

+ if (expected.time)

ctx.drawImage(video, 0, 0, width, height);

var frame = ctx.getImageData(0, 0, width, height);

@@ -46,7 +48,7 @@

video.pause();

consoleWrite("");

var expected = results.values[results.current];

- if (expected.time)

+ if (expected.time)

run("video.currentTime = " + expected.time);

setTimeout(testPixel, 100);

}

@@ -57,7 +59,7 @@

height = video.videoHeight / 2;

ctx = canvas.getContext("2d");

- ctx.fillStyle = 'yellow';

+ ctx.fillStyle = 'yellow';

ctx.fillRect(0, 0, width, height);

testFrame();

}

@@ -80,6 +82,6 @@

</div>

<p>Test <video> as a source for <canvas>.</p>

</body>

</html>