Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-text-track-destructor-crash.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/track/track-text-track-destructor-crash.html
diff --git a/third_party/WebKit/LayoutTests/media/track/track-text-track-destructor-crash.html b/third_party/WebKit/LayoutTests/media/track/track-text-track-destructor-crash.html
index c2d0760cb4521884dbde50a5b3a17515ebc39040..fcb54ee8dc4dfce362c83b2a8eb0976310505cae 100644
--- a/third_party/WebKit/LayoutTests/media/track/track-text-track-destructor-crash.html
+++ b/third_party/WebKit/LayoutTests/media/track/track-text-track-destructor-crash.html
@@ -4,6 +4,8 @@
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<script src=../media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=../video-test.js></script>
<script>
@@ -23,12 +25,12 @@
consoleWrite("SUCCESS: Did not crash");
endTest();
}
-
+
function forceGC()
{
if (window.GCController)
return GCController.collect();
-
+
// Force garbage collection
for (var ndx = 0; ndx < 99000; ndx++)
var str = new String("1234");

Powered by Google App Engine
This is Rietveld 408576698