third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/track/track-mode-disabled-crash.html ('k') | third_party/WebKit/LayoutTests/media/track/track-mode-triggers-loading.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html

diff --git a/third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html b/third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html

index c9fcf60230c2b18407efce33a487389bcb7b99f2..4bdbcf67431eda241e0df82f282e48a09c9d5346 100644

--- a/third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html

+++ b/third_party/WebKit/LayoutTests/media/track/track-mode-not-changed-by-new-track.html

@@ -4,6 +4,8 @@

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

@@ -81,7 +83,7 @@

consoleWrite("<br>EVENT(load) -- <body>");

findMediaElement();

- track1 = document.querySelectorAll('track')[0];

+ track1 = document.querySelectorAll('track')[0];

testExpected("track1.readyState", HTMLTrackElement.NONE);

testExpected("track1.track.mode", "disabled");

@@ -93,7 +95,7 @@

<p>Tests that a track appended after the initial track configuration does not change other tracks.</p>

- <video oncanplaythrough="canplaythrough()" >

+ <video oncanplaythrough="canplaythrough()" >

</video>

</body>