Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: third_party/WebKit/LayoutTests/media/remove-from-document.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/remove-from-document.html
diff --git a/third_party/WebKit/LayoutTests/media/remove-from-document.html b/third_party/WebKit/LayoutTests/media/remove-from-document.html
index d95f6aa30500472abab69a02712895495bdad315..f827e80b8470b6d2c2f70a61631ab40c58008a90 100644
--- a/third_party/WebKit/LayoutTests/media/remove-from-document.html
+++ b/third_party/WebKit/LayoutTests/media/remove-from-document.html
@@ -2,6 +2,8 @@
<html>
<head>
<script src=media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=video-test.js></script>
<script type="text/javascript" charset="utf-8">
function doSetup()
@@ -10,17 +12,17 @@
video.src = findMediaFile("video", "content/test");
}
- function doTest ()
+ function doTest ()
{
consoleWrite("EVENT(canplaythrough)");
testExpected("video.networkState", HTMLMediaElement.NETWORK_EMPTY, "!=");
testExpected("video.paused", false);
-
+
run("document.body.removeChild(video)");
-
+
testExpected("video.networkState", HTMLMediaElement.NETWORK_EMPTY, "!=");
testExpected("video.paused", true);
-
+
document.body.offsetTop;
endTest();
}

Powered by Google App Engine
This is Rietveld 408576698