third_party/WebKit/LayoutTests/media/media-source-append-multiple.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/media-source-append-multiple.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/media-reparent.html ('k') | third_party/WebKit/LayoutTests/media/no-autoplay-with-user-gesture-requirement.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/media-source-append-multiple.html

diff --git a/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html b/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html

index e0738212bbec5d522caa41cb1bdd0260da95d23d..a70efcf6f67322f4bbf99f15f019a57aa97b917d 100644

--- a/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html

+++ b/third_party/WebKit/LayoutTests/media/media-source-append-multiple.html

@@ -2,16 +2,18 @@

<html>

<head>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

var audio, sourceA, sourceB;

function canplaythrough(e)

{

testExpected("audio.currentSrc == sourceA.src", true);

endTest();

}

function loadedMetadataA()

{

consoleWrite("loadedMetadataA");

@@ -19,7 +21,7 @@

audio.appendChild(sourceB);

waitForEventAndFail("loadedmetadata");

}

function onWindowLoad(e)

{

audio = document.getElementById('a');

@@ -30,22 +32,22 @@

waitForEvent("loadeddata");

waitForEvent("canplay");

waitForEventOnce('canplaythrough', canplaythrough);

sourceA = document.createElement("source");

var audioFile = findMediaFile("audio", "content/test");

sourceA.setAttribute("src", audioFile);

sourceB = document.createElement("source");

audioFile = findMediaFile("audio", "content/silence");

sourceB.setAttribute("src", audioFile);

waitForEventOnce("loadedmetadata", loadedMetadataA);

audio.appendChild(sourceA);

}

window.addEventListener('load', onWindowLoad, false);

</script>

</head>

<body>

</body>

-</html>

+</html>