Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html
diff --git a/third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html b/third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html
index 32719d6c42c633426cc4437226b8aaf7786457bb..9eeca21d227ae94aa984e8ad5699c71f311f1922 100644
--- a/third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html
+++ b/third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html
@@ -6,6 +6,8 @@
<script src="../resources/testharnessreport.js"></script>
<script src="media-file.js"></script>
<script src="media-controls.js"></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src="video-test.js"></script>
</head>
<body>
@@ -25,7 +27,7 @@
var buttonBoundingRect = button.getBoundingClientRect();
return new Array(buttonBoundingRect.width, buttonBoundingRect.height);
}
- async_test(function(t)
+ async_test(function(t)
{
findMediaElement();
video.src = findMediaFile("video", "content/test");

Powered by Google App Engine
This is Rietveld 408576698