third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/controls-cast-do-not-fade-out.html ('k') | third_party/WebKit/LayoutTests/media/controls-css-overload.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html

diff --git a/third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html b/third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html

index 03bad40da543de9c8bc3b03b1d3bed9ba862f935..a5a421507c63a8e8534c8925f29582062df38839 100644

--- a/third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html

+++ b/third_party/WebKit/LayoutTests/media/controls-cast-overlay-slow-fade.html

@@ -6,6 +6,8 @@

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

</head>

<body>

@@ -13,7 +15,7 @@

var controls;

var test;

- // The cast button should be visible for at least the controlsMouseMovementTimeout, and no more

+ // The cast button should be visible for at least the controlsMouseMovementTimeout, and no more

// than that plus the fadeout time. Allow 500ms margin at either side.

var hideTimeoutLowerBound = controlsMouseMovementTimeoutMs - 500;

var hideTimeoutUpperBound = controlsMouseMovementTimeoutMs + controlsFadeOutDurationMs + 500;

@@ -27,7 +29,7 @@

{

findMediaElement();

video.src = findMediaFile("video", "content/test");

- video.addEventListener("playing", t.step_func(function()

+ video.addEventListener("playing", t.step_func(function()

{

setTimeout(t.step_func(function()

{

@@ -56,4 +58,4 @@

});

</script>

</body>

-</html>

+</html>