third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/video-throttled-load-metadata.html ('k') | third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/media-src-allowed.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html b/third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html

index d79da8aad40af89bcbe8f1ba46949da1a8c724b1..55d6f52141c1154cd03aceb97967beba6219a253 100644

--- a/third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html

+++ b/third_party/WebKit/LayoutTests/http/tests/media/video-useragent.html

@@ -1,9 +1,11 @@

<html>

<head>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

- function loadMediaFrame()

+ function loadMediaFrame()

{

findMediaElement();

@@ -16,12 +18,12 @@

source = document.getElementById('source');

source.src = 'http://127.0.0.1:8000/media/resources/video-check-useragent.php?name=' + movie + '&type=' + type;

source.type = type;

waitForEventAndFail('error');

waitForEventAndEnd('canplay');

video.load();

});

frame.src = "data:text/html,<b>test</b>";

document.body.appendChild(frame);

}