Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add bug ref Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html b/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html
index 948ab9343a0f37360945cbdf9c2a07418383a541..39619a92e6e9eabec3f723343222f2299626be9f 100644
--- a/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html
+++ b/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html
@@ -2,6 +2,8 @@
<html>
<head>
<script src=../../media-resources/media-file.js></script>
+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956
+ (Please avoid writing new tests using video-test.js) -->
<script src=../../media-resources/video-test.js></script>
<script>
var loadCount = 0;
@@ -11,15 +13,15 @@
testRunner.waitUntilDone();
}
- function logEvent(event)
+ function logEvent(event)
{
consoleWrite("<br><b><em>'" + event.type + "'<" + "/em> event<" + "/b>");
}
- function loadstart()
+ function loadstart()
{
logEvent(event);
-
+
if (++loadCount > 1) {
consoleWrite('FAIL: loadstart fired more than once.');
endTest();
@@ -62,4 +64,3 @@
'loadstart' event will be fired</p>
</body>
</html>
-

Powered by Google App Engine
This is Rietveld 408576698