third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/media/progress-events-generated-correctly.html ('k') | third_party/WebKit/LayoutTests/http/tests/media/remove-while-loading.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html b/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

index 948ab9343a0f37360945cbdf9c2a07418383a541..39619a92e6e9eabec3f723343222f2299626be9f 100644

--- a/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

+++ b/third_party/WebKit/LayoutTests/http/tests/media/reload-after-dialog.html

@@ -2,6 +2,8 @@

<html>

<head>

+ <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

+ (Please avoid writing new tests using video-test.js) -->

var loadCount = 0;

@@ -11,15 +13,15 @@

testRunner.waitUntilDone();

}

- function logEvent(event)

+ function logEvent(event)

{

consoleWrite("<br><b><em>'" + event.type + "'<" + "/em> event<" + "/b>");

}

- function loadstart()

+ function loadstart()

{

logEvent(event);

if (++loadCount > 1) {

consoleWrite('FAIL: loadstart fired more than once.');

endTest();

@@ -62,4 +64,3 @@

'loadstart' event will be fired</p>

</body>

</html>