third_party/WebKit/LayoutTests/media/video-width-height.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-width-height.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-volume.html ('k') | third_party/WebKit/LayoutTests/media/viewport-in-standalone-media-document.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <video width=100 height=50 controls></video>	1 <video width=100 height=50 controls></video>

	2 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	3 (Please avoid writing new tests using video-test.js) -->

2 <script src=video-test.js></script>	4 <script src=video-test.js></script>

3 <script>	5 <script>

4 testExpected("video.width", 100);	6 testExpected("video.width", 100);

5 testExpected("video.height", 50);	7 testExpected("video.height", 50);

6 testExpected("video.offsetWidth", 100);	8 testExpected("video.offsetWidth", 100);

7 testExpected("video.offsetHeight", 50);	9 testExpected("video.offsetHeight", 50);

8 video.setAttribute('width', '200');	10 video.setAttribute('width', '200');

9 video.setAttribute('height', '100');	11 video.setAttribute('height', '100');

10 testExpected("video.width", 200);	12 testExpected("video.width", 200);

11 testExpected("video.height", 100);	13 testExpected("video.height", 100);

12 testExpected("video.offsetWidth", 200);	14 testExpected("video.offsetWidth", 200);

13 testExpected("video.offsetHeight", 100);	15 testExpected("video.offsetHeight", 100);

14 video.width = 400;	16 video.width = 400;

15 video.height = 200;	17 video.height = 200;

16 testExpected("video.getAttribute('width')", 400);	18 testExpected("video.getAttribute('width')", 400);

17 testExpected("video.getAttribute('height')", 200);	19 testExpected("video.getAttribute('height')", 200);

18 testExpected("video.offsetWidth", 400);	20 testExpected("video.offsetWidth", 400);

19 testExpected("video.offsetHeight", 200);	21 testExpected("video.offsetHeight", 200);

20 endTest();	22 endTest();

21 </script>	23 </script>

OLD	NEW