third_party/WebKit/LayoutTests/media/video-src-source.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-src-source.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-src-set.html ('k') | third_party/WebKit/LayoutTests/media/video-timeupdate-during-playback.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <body>	1 <body>

2 <video><source></source></video>	2 <video><source></source></video>

3 <script src=media-file.js></script>	3 <script src=media-file.js></script>

	4 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	5 (Please avoid writing new tests using video-test.js) -->

4 <script src=video-test.js></script>	6 <script src=video-test.js></script>

5 <script>	7 <script>

6 var mediaFile = findMediaFile("video", "content/test");	8 var mediaFile = findMediaFile("video", "content/test");

7 waitForEvent('loadstart', function () {	9 waitForEvent('loadstart', function () {

8 testExpected("stripExtension(relativeURL(video.currentSrc))", stripExten sion(mediaFile));	10 testExpected("stripExtension(relativeURL(video.currentSrc))", stripExten sion(mediaFile));

9 endTest();	11 endTest();

10 } );	12 } );

11 document.getElementsByTagName('source')[0].src = "content/error.mpeg";	13 document.getElementsByTagName('source')[0].src = "content/error.mpeg";

12 mediaElement.src = mediaFile;	14 mediaElement.src = mediaFile;

13 </script>	15 </script>

OLD	NEW