third_party/WebKit/LayoutTests/media/video-source-media.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-source-media.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-source-load.html ('k') | third_party/WebKit/LayoutTests/media/video-source-moved.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <body>	1 <body>

	2 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	3 (Please avoid writing new tests using video-test.js) -->

2 <script src=video-test.js></script>	4 <script src=video-test.js></script>

3 <script>	5 <script>

4 waitForEvent('loadstart', function () {	6 waitForEvent('loadstart', function () {

5 video = mediaElement = document.getElementsByTagName('video')[0];	7 video = mediaElement = document.getElementsByTagName('video')[0];

6 testExpected("relativeURL(video.currentSrc)", "content/test.mp4");	8 testExpected("relativeURL(video.currentSrc)", "content/test.mp4");

7 endTest();	9 endTest();

8 } );	10 } );

9 </script>	11 </script>

10 <video controls>	12 <video controls>

11 <!-- the media attribute should be ignored -->	13 <!-- the media attribute should be ignored -->

12 <source src=content/test.mp4 media="print">	14 <source src=content/test.mp4 media="print">

13 <source src=content/error.mpeg>	15 <source src=content/error.mpeg>

14 </video>	16 </video>

OLD	NEW