third_party/WebKit/LayoutTests/media/video-source-error.html - Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/video-source-error.html

Issue 1715303002: Add TODOs to convert from video-test.js to testharness.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add bug ref Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/video-source-add-after-remove.html ('k') | third_party/WebKit/LayoutTests/media/video-source-error-no-candidate.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html lang="en">	1 <html lang="en">

2 <head>	2 <head>

3 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">	3 <meta http-equiv="Content-Type" content="text/html; charset=utf-8">

4 <title><video> and <source> error test</title>	4 <title><video> and <source> error test</title>

5 <script src=media-file.js></script>	5 <script src=media-file.js></script>

	6 <!-- TODO(philipj): Convert test to testharness.js. crbug.com/588956

	7 (Please avoid writing new tests using video-test.js) -->

6 <script src=video-test.js></script>	8 <script src=video-test.js></script>

7	9

8 <script>	10 <script>

9	11

10 var sources = [];	12 var sources = [];

11	13

12 function loadeddata()	14 function loadeddata()

13 {	15 {

14 consoleWrite("");	16 consoleWrite("");

15 testExpected("relativeURL(video.currentSrc)", findMediaFile("vid eo", "content/test"));	17 testExpected("relativeURL(video.currentSrc)", findMediaFile("vid eo", "content/test"));

(...skipping 42 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
58 <body>	60 <body>

59	61

60 <video controls>	62 <video controls>

61 <source id=missing-src type="video/blahblah">	63 <source id=missing-src type="video/blahblah">

62 <source id=bogus-type src=content/test.mp4 type="video/blahblah">	64 <source id=bogus-type src=content/test.mp4 type="video/blahblah">

63 <source id=missing-file src=content/error2.mpeg type=video/mpeg>	65 <source id=missing-file src=content/error2.mpeg type=video/mpeg>

64 <source id=format-error src="content/unsupported_track.mov">	66 <source id=format-error src="content/unsupported_track.mov">

65 <source id=supported-format-mp4 src=content/test.mp4 type="video/mp4 ; codecs="avc1.4D400C"">	67 <source id=supported-format-mp4 src=content/test.mp4 type="video/mp4 ; codecs="avc1.4D400C"">

66 <source id=supported-format-ogv src=content/test.ogv type="video/ogg ">	68 <source id=supported-format-ogv src=content/test.ogv type="video/ogg ">

67 </video>	69 </video>

68	70

69 <p>1. Test that errors fired while evaluating/loading <source> ele ments are fired at the	71 <p>1. Test that errors fired while evaluating/loading <source> ele ments are fired at the

70 <source> and not at the <video> element.	72 <source> and not at the <video> element.

71 <br>2. Verifiy that an 'error' event fired while processing/loading a &l t;source> element	73 <br>2. Verifiy that an 'error' event fired while processing/loading a &l t;source> element

72 does not set the media element's 'error' attribute.</p>	74 does not set the media element's 'error' attribute.</p>

73	75

74 <script>start()</script>	76 <script>start()</script>

75 </body>	77 </body>

76 </html>	78 </html>

OLD	NEW